chore: update allow list language [DHIS2-10247] #1294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-1294--dhis2-settings.netlify.app |
tomzemp
force-pushed
the
DHIS2-10247/allow-list
branch
from
cd260b9 to
f1fefc5
Compare
kabaros
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://dhis2.atlassian.net/jira/software/c/projects/DHIS2/issues/DHIS2-10247
This PR updates the label for the corsAllowlist / corsWhitelist items:
Note that while the corsAllowlist now is available from api/configurations and an alias exists for POST to api/configurations/corsAllowist, I have not changed to use these updated api endpoints because unfortunately, this app uses logic that is in d2 to transform the corsWhitelist field to the appropriate payload (https://github.com/dhis2/d2/blob/master/src/system/SystemConfiguration.js#L78). I don't think it is worth updating the d2 dependency at the moment given that api/configuration/corsWhitelist is still maintained and given that we want to overhaul settings app anyway (at which point I assume we will get rid of the dependency to d2)