feat: add in scheduling settings to settings app [DHIS2-15765] #1295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-1295--dhis2-settings.netlify.app |
jbee
reviewed
Jan 2, 2024
|
@jbee : thanks for the comments. I've made some small edits based on your comments, but feel free to suggest something else. I think we just need not overly long descriptions for within the app, but I assume that what these settings do will also be explained more fully in the documentation? |
Mohammer5
reviewed
Jan 15, 2024
Mohammer5
approved these changes
Jan 22, 2024
dhis2-bot
added a commit
that referenced
this pull request
Jan 23, 2024
# [29.16.0](v29.15.9...v29.16.0) (2024-01-23) ### Features * add in scheduling settings to settings app [DHIS2-15765] ([#1295](#1295)) ([ba6f2a1](ba6f2a1))
|
🎉 This PR is included in version 29.16.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://dhis2.atlassian.net/jira/software/c/projects/DHIS2/issues/DHIS2-15765
This adds scheduling settings into the settings app (in a new section called "Scheduled jobs" (approved by Joe on ticket)):
After
Note: the front-end validations do not appear to generally be working in the settings app, and the backend does not currently have validation of provided values [I guess we could fix the front end, but that seems like a separate ticket]
@jbee : I've tried to summarize your descriptions into shorter text for the purpose of presenting to the user in the settings app, but let me know if you think anything should be changed.