Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove oauth2 from version 42 and above #1351

Merged
merged 4 commits into from
Jun 28, 2024

Conversation

Chisomchima
Copy link
Member

@Chisomchima Chisomchima commented Jun 27, 2024

Implements DHIS2-17592

Description

conditional exclusion of the OAuth2 category in the DHIS2 settings app based on the API version. Specifically, the OAuth2 category is hidden and inaccessible when the API version is greater than 41. This change ensures that users do not see or interact with the OAuth2 settings when using versions over 41 of the DHIS2 API.


Screenshots

When API version is 41 or below (OAuth2 category visible)
Screenshot 2024-06-28 at 13 18 45
In this screenshot, the OAuth2 category is visible because the API version is 41 or below.

When API version is above 41 (OAuth2 category hidden)
Screenshot 2024-06-28 at 13 19 07
In this screenshot, the OAuth2 category is hidden because the API version is above 41. Additionally, attempting to manually navigate to the OAuth2 page in the browser will redirect you to the general settings page, ensuring users cannot access the hidden category.

@dhis2-bot
Copy link
Contributor

dhis2-bot commented Jun 27, 2024

🚀 Deployed on https://pr-1351--dhis2-settings.netlify.app

@Chisomchima Chisomchima changed the title feat: remove oauth2 section from version 42 and above feat: remove oauth2 from version 42 and above Jun 27, 2024
@Chisomchima Chisomchima requested a review from tomzemp June 28, 2024 10:48
Copy link
Member

@tomzemp tomzemp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🎉

@Chisomchima Chisomchima merged commit 71202a7 into master Jun 28, 2024
13 checks passed
@Chisomchima Chisomchima deleted the DHIS2-17592/remove-oauth branch June 28, 2024 12:33
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 100.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants