feat: add keyEmbeddedDashboardsEnabled [DHIS2-18472] #1409
Merged
+406
−116
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
keyEmbeddedDashboardsEnabled
under Analytics section (see ticket: https://dhis2.atlassian.net/browse/DHIS2-18472)maximumApiVersion
on the category level to remove oAuth2 after v41, but I noticed when adding the setting-level versioning that the search functionality was not working properly as we also have to filter categories + settings in the search spaceI think the approach here is okay. It would be more efficient to just do the filtering once and then set the results in state, or memoize the results rather than performing this filtering both when building the search space and when switching categories. However, I think the filtering operation is fairly trivial as a calculation, and I don't want to refactor more (particularly I think doing so would require reviewing the logic of the search, which seems convoluted).