fix: [DHIS2-14190] assign null instead of non-existing option (#1677)

dhis2 · Mar 22, 2023 · 37a6cdd · 37a6cdd
1 parent 39ad51a
commit 37a6cdd
Showing 1 changed file with 28 additions and 2 deletions.
diff --git a/d2-tracker/dhis2.angular.services.js b/d2-tracker/dhis2.angular.services.js
@@ -447,22 +447,48 @@ var d2Services = angular.module('d2Services', ['ngResource'])
     return {
         getCode: function(options, key){
             if(options){
+                // for comparison with the option values, which are always represented as strings
+                const keyString = String(key);
+
+                // is key a name?
                 for(var i=0; i<options.length; i++){
-                    if( key === options[i].displayName){
+                    if( keyString === options[i].displayName){
                         return options[i].code;
                     }
                 }
+                // is key a code?
+                for(var i=0; i<options.length; i++){
+                    if( keyString === options[i].code){
+                        return key;
+                    }
+                }
+                // not a part of the option set
+                return null;
             }
+
             return key;
         },
         getName: function(options, key){
             if(options){
+                // for comparison with the option values, which are always represented as strings
+                const keyString = String(key);
+
+                // is key a code?
                 for(var i=0; i<options.length; i++){
-                    if( key === options[i].code){
+                    if( keyString === options[i].code){
                         return options[i].displayName;
                     }
                 }
+                // is key a name?
+                for(var i=0; i<options.length; i++){
+                    if( keyString === options[i].displayName){
+                        return key;
+                    }
+                }
+                // not a part of the option set
+                return null;
             }
+
             return key;
         }
     };