Skip to content

Commit

Permalink
fix: remove active style from menu item with tabIndex 0
Browse files Browse the repository at this point in the history
  • Loading branch information
HendrikThePendric committed Nov 25, 2024
1 parent ce4d3ae commit 8a52497
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions components/menu/src/menu-item/menu-item.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { IconChevronRight24 } from '@dhis2/ui-icons'
import { Popper } from '@dhis2-ui/popper'
import { Portal } from '@dhis2-ui/portal'
import { IconChevronRight24 } from '@dhis2/ui-icons'

Check failure on line 3 in components/menu/src/menu-item/menu-item.js

View workflow job for this annotation

GitHub Actions / lint

`@dhis2/ui-icons` import should occur before import of `@dhis2-ui/popper`
import cx from 'classnames'
import PropTypes from 'prop-types'
import React, { useEffect, useRef, useState, useMemo } from 'react'
Expand Down Expand Up @@ -104,7 +104,7 @@ const MenuItem = ({
destructive,
disabled,
dense,
active: active || showSubMenu || tabIndex === 0,
active: active || showSubMenu,
'with-chevron': children || chevron,
})}
ref={menuItemRef}
Expand Down

0 comments on commit 8a52497

Please sign in to comment.