-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(header-bar): reduce height and minor design changes #1425
base: master
Are you sure you want to change the base?
Conversation
🚀 Deployed on https://pr-1425--dhis2-ui.netlify.app |
Passing run #3109 ↗︎
Details:
Review all test suite changes for PR #1425 ↗︎ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests should be fixed now - change looks good to me! This could be considered a breaking change depending on how people are using it (absolute positioning offsets) but I don't think we need to be strict about that. The alternative would be to do this change only in the global shell.. but not sure that's necessary
@amcgee and I discussed this further. This change will be deferred until the |
Implements LIBS-545 / UX-144
Description
This PR makes visual changes to the
HeaderBar
component:Checklist
All points above should be relevant for feature PRs. For bugfixes, some points might not be relevant. In that case, just check them anyway to signal the work is done.
Screenshots
Before:
After: