Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(header-bar): reduce height and minor design changes #1425

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

cooper-joe
Copy link
Member

@cooper-joe cooper-joe commented Nov 16, 2023

Implements LIBS-545 / UX-144


Description

This PR makes visual changes to the HeaderBar component:

  • reduce height to 40px
    • inner components are adjusted to compensate for the height reduction
  • minor adjustments to base color and interaction colors (in order to improve readability of the slightly smaller text size)

Checklist

  • API docs are generated
  • Tests were added (Not sure why the 2 tests are failing?)
  • Storybook demos were added

All points above should be relevant for feature PRs. For bugfixes, some points might not be relevant. In that case, just check them anyway to signal the work is done.


Screenshots

Before:
image

After:
image

@cooper-joe cooper-joe requested a review from a team as a code owner November 16, 2023 11:59
@dhis2-bot
Copy link
Contributor

dhis2-bot commented Nov 16, 2023

🚀 Deployed on https://pr-1425--dhis2-ui.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify November 16, 2023 12:03 Inactive
Copy link

cypress bot commented Nov 16, 2023

Passing run #3109 ↗︎

0 583 0 0 Flakiness 0

Details:

chore: fix headerbar cypress tests
Project: ui Commit: e0be96364b
Status: Passed Duration: 06:35 💡
Started: Nov 16, 2023 6:42 PM Ended: Nov 16, 2023 6:49 PM

Review all test suite changes for PR #1425 ↗︎

@dhis2-bot dhis2-bot temporarily deployed to netlify November 16, 2023 12:18 Inactive
@amcgee amcgee self-requested a review November 16, 2023 18:36
Copy link
Member

@amcgee amcgee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests should be fixed now - change looks good to me! This could be considered a breaking change depending on how people are using it (absolute positioning offsets) but I don't think we need to be strict about that. The alternative would be to do this change only in the global shell.. but not sure that's necessary

@dhis2-bot dhis2-bot temporarily deployed to netlify November 16, 2023 18:40 Inactive
@cooper-joe cooper-joe marked this pull request as draft November 17, 2023 08:26
@cooper-joe
Copy link
Member Author

cooper-joe commented Nov 17, 2023

The alternative would be to do this change only in the global shell

@amcgee and I discussed this further. This change will be deferred until the HeaderBar is moved to the global shell. Keeping this PR in draft as the design changes are approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants