Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: menu item suffix #1427

Merged
merged 4 commits into from
Dec 7, 2023
Merged

feat: menu item suffix #1427

merged 4 commits into from
Dec 7, 2023

Conversation

cooper-joe
Copy link
Member

@cooper-joe cooper-joe commented Nov 21, 2023

Implements LIBS-536


Description

This PR adds the optional suffix prop to <MenuItem>. A suffix is displayed at the end of the component. A suffix can be used alongside chevron: true.


Checklist

  • API docs are generated
  • Tests were added
  • Storybook demos were added

All points above should be relevant for feature PRs. For bugfixes, some points might not be relevant. In that case, just check them anyway to signal the work is done.


Screenshots

image

image

@cooper-joe cooper-joe requested a review from a team as a code owner November 21, 2023 14:31
@dhis2-bot
Copy link
Contributor

dhis2-bot commented Nov 21, 2023

🚀 Deployed on https://pr-1427--dhis2-ui.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify November 21, 2023 14:35 Inactive
Copy link

cypress bot commented Nov 21, 2023

Passing run #3125 ↗︎

0 584 0 0 Flakiness 0

Details:

docs(menu-item): add suffix and chevron story
Project: ui Commit: 6c0bee8b2a
Status: Passed Duration: 06:40 💡
Started: Nov 23, 2023 9:59 AM Ended: Nov 23, 2023 10:06 AM

Review all test suite changes for PR #1427 ↗︎

Copy link
Contributor

@Mohammer5 Mohammer5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a functional perspective this looks good! Could you add a story with both the chevron and the suffix? That way it's clear that both can be used together and we can see what it looks like, too

@dhis2-bot dhis2-bot temporarily deployed to netlify November 23, 2023 09:57 Inactive
Copy link
Member

@Birkbjo Birkbjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM

@cooper-joe cooper-joe merged commit f2da57d into master Dec 7, 2023
13 checks passed
@cooper-joe cooper-joe deleted the menu-item-suffix branch December 7, 2023 09:06
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 8.16.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 9.0.0-alpha.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants