Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: change import/notice about import & add codeblocks #1442

Merged
merged 28 commits into from
Apr 30, 2024

Conversation

Topener
Copy link
Contributor

@Topener Topener commented Jan 2, 2024

An improvement in the UI docs to give more clarity and examples.

Todo before merge

  • Undo the GitHub workflow changes

@Topener Topener force-pushed the ui-docs-improvement branch from c9b042c to 9536eed Compare January 2, 2024 16:31
@dhis2-bot
Copy link
Contributor

dhis2-bot commented Jan 2, 2024

🚀 Deployed on https://pr-1442--dhis2-ui.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify January 2, 2024 16:35 Inactive
Copy link

cypress bot commented Jan 2, 2024

Passing run #3349 ↗︎

0 584 0 0 Flakiness 0

Details:

docs: change import/notice about import & add codeblocks (#1442)
Project: ui Commit: c8daca4f64
Status: Passed Duration: 08:42 💡
Started: Apr 30, 2024 12:29 PM Ended: Apr 30, 2024 12:38 PM

Review all test suite changes for PR #1442 ↗︎

@dhis2-bot dhis2-bot temporarily deployed to netlify January 2, 2024 17:03 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify January 3, 2024 13:48 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify January 3, 2024 16:01 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify January 3, 2024 16:56 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify February 5, 2024 14:48 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify March 4, 2024 13:45 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify March 4, 2024 13:58 Inactive
@Topener Topener changed the title docs: change import/ notice about import [WIP] docs: change import/notice about import & add codeblocks [WIP] Mar 4, 2024
@dhis2-bot dhis2-bot temporarily deployed to netlify March 4, 2024 15:28 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify March 4, 2024 20:53 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify April 17, 2024 13:46 Inactive
@Topener Topener changed the title docs: change import/notice about import & add codeblocks [WIP] docs: change import/notice about import & add codeblocks Apr 17, 2024
@dhis2-bot dhis2-bot temporarily deployed to netlify April 17, 2024 14:06 Inactive
@Topener Topener marked this pull request as ready for review April 17, 2024 14:07
@Topener Topener requested a review from a team as a code owner April 17, 2024 14:07
Copy link
Member

@Birkbjo Birkbjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one minor comment

docs/docs/components/calendar-input.md Outdated Show resolved Hide resolved
Copy link
Member

@tomzemp tomzemp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I agree with Birk's comment.

docs/docs/components/calendar-input.md Outdated Show resolved Hide resolved
@dhis2-bot dhis2-bot temporarily deployed to netlify April 29, 2024 15:58 Inactive
@tomzemp tomzemp merged commit c8daca4 into master Apr 30, 2024
13 checks passed
@tomzemp tomzemp deleted the ui-docs-improvement branch April 30, 2024 12:23
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 9.4.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants