Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rtl cleanup #1450

Merged
merged 3 commits into from
Feb 13, 2024
Merged

fix: rtl cleanup #1450

merged 3 commits into from
Feb 13, 2024

Conversation

tomzemp
Copy link
Member

@tomzemp tomzemp commented Feb 12, 2024 •
edited
Loading

Fixes for LIBS-525

Description

This adds some fixes to

  • right align elements in rtl
  • address problems with use of :dir(rtl) pseudoclass in firefox. svg icons do not respect icons, so need to either wrap the icon in a div and apply pseudoclass there, or set dir on svg itself and use svg[dir='rtl'].

    • Known issues

    • There are still issues with :dir(rtl) transformations in Opera and Safari that do not appear to be fixed by the changes
    • The RTL story for Switch component is not working in Firefox (outside of Storybook it appears to work)

    Checklist

    • API docs are generated
    • Tests were added
    • Storybook demos were added

    Storybook added for <Table>. Otherwise no updates.

@tomzemp tomzemp requested a review from a team as a code owner February 12, 2024 11:56
@tomzemp tomzemp requested review from kabaros and a team and removed request for a team February 12, 2024 11:57
@tomzemp tomzemp changed the title Rtl cleanup fix: rtl cleanup Feb 12, 2024
@dhis2-bot
Copy link
Contributor

🚀 Deployed on https://pr-1450--dhis2-ui.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify February 12, 2024 12:02 Inactive
@cypress Cypress
Copy link

cypress bot commented Feb 12, 2024

Passing run #3216 ↗︎

0 584 0 0 Flakiness 0

Details:

fix: auto generated files
Project: ui Commit: 41cdf5bd36
Status: Passed Duration: 06:44 💡
Started: Feb 12, 2024 12:02 PM Ended: Feb 12, 2024 12:09 PM

Review all test suite changes for PR #1450 ↗︎

@tomzemp tomzemp merged commit 5f6761f into alpha Feb 13, 2024
21 of 23 checks passed
@tomzemp tomzemp deleted the rtl-cleanup branch February 13, 2024 09:50
@cypress cypress bot mentioned this pull request Feb 13, 2024
Merged
6 tasks
dhis2-bot added a commit that referenced this pull request Feb 13, 2024
@dhis2-bot
chore(release): cut 9.3.0-alpha.2 [skip release]
8586690 
# [9.3.0-alpha.2](v9.3.0-alpha.1...v9.3.0-alpha.2) (2024-02-13)

### Bug Fixes

* rtl cleanup ([#1450](#1450)) ([5f6761f](5f6761f))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 9.3.0-alpha.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

dhis2-bot added a commit that referenced this pull request Feb 14, 2024
@dhis2-bot
chore(release): cut 9.4.0-alpha.1 [skip release]
7482f2d 
# [9.4.0-alpha.1](v9.3.0...v9.4.0-alpha.1) (2024-02-14)

### Bug Fixes

* rtl cleanup ([#1450](#1450)) ([5f6761f](5f6761f))

### Features

* rtl support for components [LIBS-525] ([#1448](#1448)) ([d8b5fec](d8b5fec))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 9.4.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kabaros kabaros kabaros approved these changes

Assignees
No one assigned
Labels
released on @alpha
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomzemp @dhis2-bot @kabaros