feat: update accessibility in button component #1451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-1451--dhis2-ui.netlify.app |
Chisomchima
changed the title
kabaros
approved these changes
Feb 12, 2024
Passing run #3218 ↗︎
Details:
Review all test suite changes for PR #1451 ↗︎ |
|||||||||||||||
cooper-joe
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
Looks good to me 👍
As an aside, as mentioned on the ticket, I think it would be nice to introduce some soft warning or linting if there is no button label and there is no aria-label. However, we may want to address this as a library wide linting strategy, so deferring for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: update accessibility in button component
Description
Implemented JIRA_ISSUE_ID by updating the Button component to handle
titleandaria-labelattributes passed as part ofotherProps. This change ensures that accessibility attributes can be easily included when using the Button component.Known issues
Checklist
All points above should be relevant for feature PRs. For bugfixes, some points might not be relevant. In that case, just check them anyway to signal the work is done.
Screenshots
Additional Notes
Buttoncomponent to destructuretitleandariaLabelfromotherPropsand apply them to the<button>element.titleandaria-labelattributes are correctly passed to the rendered<button>element.otherPropswhile maintaining accessibility.supporting text