chore: update modal accessibility and translation #1465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-1465--dhis2-ui.netlify.app |
4 failed tests on run #3393 ↗︎
Details:
|
|||||||||||||||
kabaros
force-pushed
the
LIBS-567/modal-accessibility-translation
branch
4 times, most recently
from
5631917 to
db9d5be
Compare
kabaros
approved these changes
Apr 25, 2024
There was a problem hiding this comment.
@Chisomchima tested and worked as expected. I updated the PR to delete some files that shouldn't have been there - when you merge it, then please squash merge it.
Chisomchima
force-pushed
the
LIBS-567/modal-accessibility-translation
branch
from
db9d5be to
61b1231
Compare
chore: remove unnecessary files in PR chore: update modal accessibility and translation
Chisomchima
force-pushed
the
LIBS-567/modal-accessibility-translation
branch
from
61b1231 to
8f7b8b8
Compare
…ssibility-translation
Birkbjo
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements Jira Ticket
Description
Implements Jira Ticket by updating the Modal CloseButton component to update
titleandaria-labelattributes, as well as the close onClick of the escape buttonKnown issues