Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve accessibility of headerbar notification icons and profile #1469

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

Chisomchima
Copy link
Member

@Chisomchima Chisomchima commented Mar 29, 2024

Implements LIBS-564

Description

update accessibility for HeaderBar component by Add title and aria-label attributes to icon-only buttons.

@Chisomchima Chisomchima requested a review from a team as a code owner March 29, 2024 07:43
@Chisomchima Chisomchima requested a review from kabaros March 29, 2024 07:43
@dhis2-bot
Copy link
Contributor

dhis2-bot commented Mar 29, 2024

🚀 Deployed on https://pr-1469--dhis2-ui.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify March 29, 2024 07:47 Inactive
Copy link

cypress bot commented Mar 29, 2024

Passing run #3342 ↗︎

0 584 0 0 Flakiness 0

Details:

chore: improve accessibility of headerbar notification icons and profile
Project: ui Commit: b023ca1511
Status: Passed Duration: 06:45 💡
Started: Apr 25, 2024 4:10 PM Ended: Apr 25, 2024 4:17 PM

Review all test suite changes for PR #1469 ↗︎

@Chisomchima Chisomchima changed the base branch from master to alpha April 9, 2024 10:11
@kabaros kabaros changed the base branch from alpha to master April 25, 2024 15:56
@kabaros kabaros force-pushed the LIBS-564/headerbar-accessibility branch from 4aebb2d to b023ca1 Compare April 25, 2024 16:02
@dhis2-bot dhis2-bot temporarily deployed to netlify April 25, 2024 16:06 Inactive
@Chisomchima Chisomchima requested a review from d-rita May 28, 2024 08:28
@kabaros kabaros merged commit 0df456c into master Jun 3, 2024
13 checks passed
@kabaros kabaros deleted the LIBS-564/headerbar-accessibility branch June 3, 2024 10:14
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 9.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants