feat(FileListItem): accessibility improvements for FileListItem #1474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-1474--dhis2-ui.netlify.app |
Birkbjo
reviewed
Apr 16, 2024
| event.key === 'Backspace' || | ||
| event.key === 'Delete' | ||
| ) { | ||
| onRemove({}, event) |
There was a problem hiding this comment.
Do we want to call event.stopPropagation here?
d-rita
approved these changes
May 24, 2024
Passing run #3405 ↗︎
Details:
Review all test suite changes for PR #1474 ↗︎ |
|||||||||||||||
dhis2-bot
added a commit
that referenced
this pull request
May 29, 2024
# [9.5.0](v9.4.9...v9.5.0) (2024-05-29) ### Features * **FileListItem:** accessibility improvements for FileListItem ([#1474](#1474)) ([b5d5e2d](b5d5e2d))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements LIBS-562
Description
Remove action in list of attached files is focusable and triggerable with
enter&deletekeys.Checklist