Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(github action): use node v20 in deploy tasks #1489

Merged
merged 3 commits into from
May 6, 2024

Conversation

Mohammer5
Copy link
Contributor

@Mohammer5 Mohammer5 commented May 1, 2024

Blocked by dhis2/cli-utils-cypress#399

Description

I broke the deploy GH workflow with my most recent PR, see here.
This should address the issues.

@Mohammer5 Mohammer5 requested a review from tomzemp May 1, 2024 07:44
@Mohammer5 Mohammer5 requested a review from a team as a code owner May 1, 2024 07:44
@dhis2-bot
Copy link
Contributor

dhis2-bot commented May 1, 2024

🚀 Deployed on https://pr-1489--dhis2-ui.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify May 1, 2024 07:48 Inactive
Copy link

cypress bot commented May 1, 2024

Passing run #3353 ↗︎

0 584 0 0 Flakiness 0

Details:

Merge pull request #1489 from dhis2/fix-gh-workflows
Project: ui Commit: 57e84d5dd5
Status: Passed Duration: 08:55 💡
Started: May 6, 2024 12:58 AM Ended: May 6, 2024 1:07 AM

Review all test suite changes for PR #1489 ↗︎

@dhis2-bot dhis2-bot temporarily deployed to netlify May 1, 2024 11:40 Inactive
Copy link
Contributor

@Topener Topener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mohammer5 Mohammer5 merged commit 57e84d5 into master May 6, 2024
13 checks passed
@Mohammer5 Mohammer5 deleted the fix-gh-workflows branch May 6, 2024 00:50
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 9.4.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants