Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix failing command palette tests #1646

Merged
merged 3 commits into from
Dec 17, 2024

Conversation

d-rita
Copy link
Contributor

@d-rita d-rita commented Dec 2, 2024

  • This PR fixes the failing tests related to the command palette after the React 18 upgrade. By using the fireEvent API (instead of the originally used userEvent API) to simulate keyboard events, i.e. pressing Ctrl/Meta + /, to simulate the opening and closing of the command palette modal.

@d-rita d-rita requested a review from a team as a code owner December 2, 2024 11:02
Copy link

sonarqubecloud bot commented Dec 2, 2024

@dhis2-bot
Copy link
Contributor

🚀 Deployed on https://pr-1646--dhis2-ui.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify December 2, 2024 11:06 Inactive
@amcgee
Copy link
Member

amcgee commented Dec 17, 2024

LGTM! 🎉

@amcgee amcgee merged commit 1970312 into feature-command-palette Dec 17, 2024
17 checks passed
@amcgee amcgee deleted the test/command-palette-tests branch December 17, 2024 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants