fix: allow input field to have zero value #1647
Conversation
|
🚀 Deployed on https://pr-1647--dhis2-ui.netlify.app |
flaminic
changed the title
| value={ | ||
| value === null || | ||
| value === undefined || | ||
| Number.isNaN(value) | ||
| ? '' | ||
| : value | ||
| } |
There was a problem hiding this comment.
Could this just use a nullish coalescing operator? Are we also trying to handle NaN falsy values or just trying to make sure 0 can be passed?
| value={ | |
| value === null || | |
| value === undefined || | |
| Number.isNaN(value) | |
| ? '' | |
| : value | |
| } | |
| value={value ?? ''} |
There was a problem hiding this comment.
Yes, i was not sure here. I doubt NaN is ever going to be passed as a value, but I thought maybe safer to keep the previous behaviour for everything that is not 0, -0 or other forms of 0? But happy to change it as well. Do you think ?? would be better?
|
|
I'm fine with either here @flaminic ! The one important thing I think is that if we're intending to have defined behavior for NaN values (the solution as written now) then we should make sure we have a unit test for that case. |
Description
This fixes changing number fields with value 0 to having value ""
Checklist
All points above should be relevant for feature PRs. For bugfixes, some points might not be relevant. In that case, just check them anyway to signal the work is done.
Screenshots
supporting text