Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow input field to have zero value #1647

Closed
wants to merge 3 commits into from
Closed

fix: allow input field to have zero value #1647

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b7c2e72
fix: allow zero as a value for input field
flaminic Dec 4, 2024
963586a
fix: allow 0 as a value for input field
flaminic Dec 4, 2024
c7006f4
fix: use nullish coalescing operatorin input field to check if value …
flaminic Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions components/input/src/input-field/__tests__/input-field.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,12 @@ describe('<Input>', () => {

expect(onKeyDown).toHaveBeenCalledTimes(1)
})

it('should render a field with value zero', () => {
const screen = render(
<InputField label="label" name="foo" type="number" value={0} />
)

expect(screen.getByLabelText('label')).toHaveValue(0)
})
})
2 changes: 1 addition & 1 deletion components/input/src/input-field/input-field.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ class InputField extends React.Component {
onChange={onChange}
name={name}
type={type}
value={value || ''}
value={value ?? ''}
placeholder={placeholder}
disabled={disabled}
max={max}
Expand Down
Loading