Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transfer): adjust filter inputs and container spacing [LIBS-728] #1650

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

cooper-joe
Copy link
Member

@cooper-joe cooper-joe commented Dec 16, 2024

Implements LIBS-728


Description

This PR makes two minor style changes to Transfer:

  • Use dense inputs for the default filter inputs
  • Apply margin to first and last options, rather than the options container, which removes the spacing above/below the scrollbar.

Checklist

  • API docs are generated
  • Tests were added
  • Storybook demos were added

All points above should be relevant for feature PRs. For bugfixes, some points might not be relevant. In that case, just check them anyway to signal the work is done.


Screenshots

Before 1:

image

After 1:

image

Before 2:

image

After 2:

image

@cooper-joe cooper-joe requested a review from a team as a code owner December 16, 2024 09:05
@dhis2-bot
Copy link
Contributor

🚀 Deployed on https://pr-1650--dhis2-ui.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify December 16, 2024 09:09 Inactive
Copy link
Contributor

@simonadomnisoru simonadomnisoru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@d-rita d-rita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cooper-joe cooper-joe merged commit 7db90b0 into master Dec 18, 2024
20 checks passed
@cooper-joe cooper-joe deleted the feat/LIBS-728 branch December 18, 2024 09:17
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 10.1.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants