Update Schema and Data Loading Script for PoE Items #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- store price info as-is, skipping json serialization - aptly convert pricing decimal types when loading or storing data
- use new league - remove outdated 'Coffins' category group - set category's internal name rather than link to category record on item - make ItemSparkline's fields nullable
- update script to accommodate latest changes - start integrating message passing using queues for efficiency - wip: use concurrenct API calls to get price history data for multiple items
This reverts commit a34fc04.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new fields, removes some old fields, and updates the data loading script to get data for the new Path of Exile 'Settlers' league. Previous leagues' exclusive items have been removed and support for new items has been added.
This also includes a couple of minor bug fixes and other relevant changes.