Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't try to connect_telnet on Windows when '-p COMx' is specified #232

Closed
wants to merge 18 commits into from
Closed

Conversation

github0null
Copy link

Hello,

I noticed this case can't work on Windows, because windows serial port name usually is: 'COMxx', not include '/'

rshell/rshell/main.py

Lines 1420 to 1427 in 56f75cf

def connect(port, baud=115200, user='micro', password='python', wait=0):
"""Tries to connect automagically via network or serial."""
if '/' in port:
connect_serial(port, baud=baud, wait=wait)
else:
try:
ip_address = socket.gethostbyname(port)
#print('Connecting to ip', ip_address)

So it always try connect_telnet and elapse more time.

#202

@dhylands
Copy link
Owner

So you've combined 3 different things in this MR. The thing about -p COMx, the tree command, and more verbose output for some of the commands.

Each one of these should be done as a separate PR.

@github0null github0null closed this by deleting the head repository Aug 12, 2024
@github0null
Copy link
Author

Very sorry,

Since I was trying to develop something else on my fork, there were some junk commits, and i'll start over with a clean PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants