Feat: Youtube Integration #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wow! thanks for PR, this looks amazing. gonna review it shortly |
fsher
reviewed
Oct 23, 2024
packages/blinks/src/index.css
Outdated
| @@ -6,6 +6,11 @@ | |||
| .blink { | |||
| container-type: inline-size; | |||
| } | |||
| /* Restricting the Width only for Youtube - can be done either ways */ | |||
| /* Can also change depending on the platform */ | |||
| .blink.youtube-dark, .blink.youtube-light { | |||
There was a problem hiding this comment.
I'd recommend controlling the width through youtube.tsx, where the injected Blink component is rendered with a max-w wrapper
There was a problem hiding this comment.
meaning: createYouTubeAction's div with stopPropagation
There was a problem hiding this comment.
Done, Please check the below Commit : 6e02c65
|
@fsher @zhelezkov any update on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the functionality for rendering blinks and actions from youtube.
Demo here : https://youtu.be/xSMyBGzGGtc
The Files changed include :
Youtube.tsx - The logic of detecting the comments section, validating if it's a blink url and rendering the Blink happens here.
Package.json - exports from the paths of the build folder (dist)
index.css - added the styles for
StylePreset- youtube-light and youtube-darktypes.ts, presets.ts, postcss.config.js - added the StylePresets
Minute changes in :
useActionSolanaWalletAdapter - Fixes the Buffer error on the base64 conversion (sometimes)
blinks/src/index.ts - Added missing import