This repository has been archived by the owner on Feb 15, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hapi allows defining custom validation functions in the
validate
route option (see the test in the PR). These functions can throw an error that's not a Joi error, which triggers a type error in Relish:Since Relish is designed to handle Joi errors, this PR proposes to fix the error by early returning when the handled error is not a Joi error.
Separately, to test I installed Boom, which caused huge changes in the package-lock.json. If you have any tips on how to minimize those changes, I'm all ears. Thanks for considering my PR!