Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add accessibility settings, implement image preview field #2449

Merged
merged 4 commits into from
Jan 7, 2025

Conversation

salianifo
Copy link
Contributor

Adds a new accessibility settings page with the following settings:

  • Image preview height [default: 50 px] (used for the image preview field)
  • Event block bottom margin [default: 0 px] (used to add some extra space between event blocks to improve readability)
  • Show event names in timeline [default: false] (adds a header label to the beginning of all events with the event name to help distinguish events better)

The image previews are automatically unloaded when the event block body is hidden, and not loaded at all if image preview height is set to 0. Image preview size and event block bottom margin are scaled according to the editor scale (DialogicUtil.get_editor_scale()). The settings page includes hints noting that some settings require reloading the visual timeline for changes to take effect.

@salianifo salianifo force-pushed the accessibility-settings branch from b8d0034 to bf105a3 Compare October 26, 2024 19:37
@salianifo salianifo marked this pull request as ready for review October 26, 2024 19:39
This also makes the editor settings instantly apply to the visual timeline editor (including the color palette).
@Jowan-Spooner
Copy link
Member

I made a bunch of changes:

  • Renames the Accessibility Page to "Editor"
  • Moves the Color Palette and Section Order settings to the new Editor page
  • Stores all those editor settings as DialogicUtil Editor settings instead.
  • Makes all the relevant editor settings reload the timeline editor (including color palette and the new settings).

@Jowan-Spooner
Copy link
Member

I think it's good enough for now. Thanks for all the work!

@Jowan-Spooner Jowan-Spooner merged commit 507c81c into dialogic-godot:main Jan 7, 2025
3 checks passed
@salianifo salianifo deleted the accessibility-settings branch January 7, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants