Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Play from here #2535

Merged
merged 2 commits into from
Feb 16, 2025

Conversation

Jowan-Spooner
Copy link
Member

Similar to @firedfromlife 's implementation over at #2357, this PR adds a right-click menu option to both the Visual and the Text editor that allows playing a timeline from the given point.

This somewhat addresses #1181.

This method can also be triggered with Ctrl+F6 or Ctrl+Shift+B on macOS.

Adds a play from here option to the right click menu both in the visual editor and the text editor. The action can also be triggered with Ctrl+F6 or Ctrl+Shift+B on macOS. Those shortcuts have been added to the shortcut cheat sheet.

The text editor thing required a new method on the timeline resource that I'm not super pleased with, but it works. It works by keeping an index of all the lines and the event index they end at. I hope this doesn't have a big impact on timeline processing, but I don't think it should.
@Jowan-Spooner Jowan-Spooner merged commit 5d96384 into dialogic-godot:main Feb 16, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant