remove from tab_group, add to tooltip

dialpad · Oct 2, 2024 · 643cb50 · 643cb50
1 parent 481e601
commit 643cb50
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/packages/dialtone-vue3/components/tabs/tab_group.vue b/packages/dialtone-vue3/components/tabs/tab_group.vue
@@ -33,7 +33,6 @@
 </template>
 
 <script>
-import { warnIfUnmounted } from '@/common/utils';
 import {
   TAB_LIST_SIZES,
   TAB_LIST_KIND_MODIFIERS,
@@ -172,7 +171,6 @@ export default {
 
   mounted () {
     this.updateSelected();
-    warnIfUnmounted(this.$el, this.$options.name);
   },
 
   beforeUpdate () {

diff --git a/packages/dialtone-vue3/components/tooltip/tooltip.vue b/packages/dialtone-vue3/components/tooltip/tooltip.vue
@@ -50,7 +50,7 @@ import {
 import {
   POPOVER_APPEND_TO_VALUES,
 } from '../popover/popover_constants';
-import { flushPromises, getUniqueString, hasSlotContent } from '@/common/utils';
+import { flushPromises, getUniqueString, hasSlotContent, warnIfUnmounted } from '@/common/utils';
 import {
   createTippy,
   getAnchor,
@@ -362,6 +362,7 @@ export default {
       await flushPromises();
       this.addExternalAnchorEventListeners();
     }
+    warnIfUnmounted(this.$el, this.$options.name);
   },
 
   beforeUnmount () {

diff --git a/packages/dialtone-vue3/directives/tooltip/tooltip.test.js b/packages/dialtone-vue3/directives/tooltip/tooltip.test.js
@@ -44,6 +44,7 @@ describe('DtTooltipDirective Tests', () => {
         },
         plugins: [DtTooltipDirective],
       },
+      attachTo: document.body,
     });
 
     anchor = wrapper.find('button');