Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: alpha/beta releases #120

Merged
merged 35 commits into from
Jan 24, 2024
Merged

ci: alpha/beta releases #120

merged 35 commits into from
Jan 24, 2024

Conversation

juliodialpad
Copy link
Collaborator

@juliodialpad juliodialpad commented Jan 22, 2024

CI: Alpha / Beta releases

Obligatory GIF (super important!)

Obligatory GIF

🛠️ Type Of Change

These types will increment the version number on release:

  • Fix
  • Feature
  • Performance Improvement
  • Refactor

These types will not increment the version number, but will still deploy to documentation site on release:

  • Documentation
  • Build system
  • CI
  • Style (code style changes, not css changes)
  • Test
  • Other (chore)

📖 Jira Ticket

https://dialpad.atlassian.net/browse/DLT-1484

📖 Description

  • Added arguments and updated release.sh script to support releasing alpha and beta.
  • Tested releasing alpha versions on dialtone, dialtone-vue2 and dialtone-tokens and it worked fine.
  • Well need to verify after merge that every repo can be released on alpha/beta correctly.

💡 Context

After migrating to monorepo we were missing the ability to release alpha/beta versions.

📝 Checklist

For all PRs:

  • I have ensured no private Dialpad links or info are in the code or pull request description (Dialtone is a public repo!).
  • I have reviewed my changes.
  • I have added all relevant documentation.
  • I have considered the performance impact of my change.

🔮 Next Steps

  • Test the release to verify that everything is working properly.

juliodialpad and others added 26 commits January 22, 2024 12:17
## [1.23.6-alpha.1](dialtone-tokens/v1.23.5...dialtone-tokens/v1.23.6-alpha.1) (2024-01-22)

### Bug Fixes

* remove release command from tokens ([ef84641](ef84641))
# [9.7.0-alpha.2](dialtone/v9.7.0-alpha.1...dialtone/v9.7.0-alpha.2) (2024-01-22)

### Bug Fixes

* force delete pre-release branch ([4b44324](4b44324))
* increase parallel build ([d589bc3](d589bc3))
* remove release command from tokens ([ef84641](ef84641))
* test alpha release ([4c9f966](4c9f966))
@juliodialpad juliodialpad changed the title Ci/alpha beta releases ci: alpha/beta releases Jan 22, 2024
@juliodialpad juliodialpad self-assigned this Jan 22, 2024
# Conflicts:
#	CHANGELOG.json
#	CHANGELOG.md
#	package.json
#	packages/dialtone-vue2/CHANGELOG.json
#	packages/dialtone-vue2/CHANGELOG.md
#	packages/dialtone-vue2/package.json
@juliodialpad juliodialpad added the no-visual-test Add this tag when the PR does not need visual testing label Jan 22, 2024
Copy link

✔️ Deploy previews ready!
😎 Dialtone preview: https://dialtone.dialpad.com/deploy-previews/pr-120/
😎 Dialtone-vue 2 preview: https://dialtone.dialpad.com/vue/deploy-previews/pr-120/
😎 Dialtone-vue 3 the preview: https://dialtone.dialpad.com/vue3/deploy-previews/pr-120/

@ninamarina
Copy link
Contributor

I have a question related to this, although not particularly with the code: which are our alpha / beta users? how much time does a feature stay in alpha / beta before going to production?

@juliodialpad
Copy link
Collaborator Author

I have a question related to this, although not particularly with the code: which are our alpha / beta users? how much time does a feature stay in alpha / beta before going to production?

We don't really have a specific workflow of putting something into alpha/beta and then promoting to staging, we mostly use alpha/beta when we need to test something on product before making the actual release.

@braddialpad
Copy link
Contributor

Yes it can be used for any situation where we need to do a "side release" for some reason. Testing stuff on product is one usage. Another one is fixing bugs in Dialpad beta. If there is a Dialtone related bug in beta that needs to be fixed before release we might not want to just push the latest dialtone update to beta that has 8 other updates in it because that could potentially break something else. In this case we could make a release on the alpha or beta branch that is the same version dialpad beta is using with just the bug fix added to it.

README.md Outdated
@@ -113,11 +113,27 @@ pnpm nx build dialtone-documentation

### Releasing

Running this commands will automatically release all packages that need to be released.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"this command" or "these commands"

README.md Outdated

#### Production

Note: needs to be run while on staging branch.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slightly more detail about what this command actually does.

Merges staging to production branch
publishes the library package to npm
deploys the documentation site.

README.md Outdated

#### Alpha/Beta

Note: needs to be run while on your feature branch.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this one, detail how it:

Merges the feature branch you are currently on to the "alpha" or "beta" branch
publishes the library package to npm under the @Alpha or @beta distribution tag.

@@ -1,3 +1,10 @@
## [1.23.6-alpha.1](https://github.com/dialpad/dialtone/compare/dialtone-tokens/v1.23.5...dialtone-tokens/v1.23.6-alpha.1) (2024-01-22)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm should alpha releases actually show up in this changelog?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were showing them before on dialtone-vue and legacy dialtone. I remember having issues with them but I think they were because we weren't merging changes back.

I'll check if there's a way to only put "production" changes on the changelog.

@@ -1,6 +1,6 @@
{
"name": "@dialpad/dialtone-tokens",
"version": "1.23.5",
"version": "1.23.6-alpha.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't want to merge this version to staging right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I'll revert that changes.

I don't think we'll have issues with versions as the tags will be kept.

Copy link

✔️ Deploy previews ready!
😎 Dialtone preview: https://dialtone.dialpad.com/deploy-previews/pr-120/
😎 Dialtone-vue 2 preview: https://dialtone.dialpad.com/vue/deploy-previews/pr-120/
😎 Dialtone-vue 3 the preview: https://dialtone.dialpad.com/vue3/deploy-previews/pr-120/

Copy link

✔️ Deploy previews ready!
😎 Dialtone preview: https://dialtone.dialpad.com/deploy-previews/pr-120/
😎 Dialtone-vue 2 preview: https://dialtone.dialpad.com/vue/deploy-previews/pr-120/
😎 Dialtone-vue 3 the preview: https://dialtone.dialpad.com/vue3/deploy-previews/pr-120/

Copy link

✔️ Deploy previews ready!
😎 Dialtone preview: https://dialtone.dialpad.com/deploy-previews/pr-120/
😎 Dialtone-vue 2 preview: https://dialtone.dialpad.com/vue/deploy-previews/pr-120/
😎 Dialtone-vue 3 the preview: https://dialtone.dialpad.com/vue3/deploy-previews/pr-120/

Copy link
Contributor

@braddialpad braddialpad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@juliodialpad juliodialpad merged commit 4f8c2ce into staging Jan 24, 2024
7 checks passed
@juliodialpad juliodialpad deleted the ci/alpha-beta-releases branch January 24, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-visual-test Add this tag when the PR does not need visual testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants