fix(feed-item-row, emoji-row): spacing / color fixes - Vue 3 #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braddialpad
requested review from
juliodialpad,
iropolo,
francisrupert and
ninamarina
as code owners
braddialpad
added
the
visual-test-ready
|
✔️ Deploy previews ready! |
iropolo
reviewed
Jan 30, 2024
| } | ||
| padding-right: var(--dt-space-300); | ||
| padding-left: var(--dt-space-0); | ||
| // min-width = avatar width + padding |
There was a problem hiding this comment.
Would change it to /* min-width = avatar width + padding */
It could get confused if it is with //
iropolo
approved these changes
Jan 30, 2024
|
✔️ Deploy previews ready! |
braddialpad
pushed a commit
that referenced
this pull request
Feb 1, 2024
# [3.106.0](dialtone-vue3/v3.105.2...dialtone-vue3/v3.106.0) (2024-02-01) ### Bug Fixes * change padding on right slot of call pill stories ([#138](#138)) ([9a23a42](9a23a42)) * **Feed Item Row, Emoji Row:** spacing / color fixes - Vue 3 ([#134](#134)) ([21f3e21](21f3e21)) * **Feed Item Row:** set inset focus ring on feed item ([#139](#139)) ([e4e935a](e4e935a)) ### Features * **Wysiwyg Editor, Rich Text Editor:** add wysiwyg component ([#113](#113)) ([367d3e2](367d3e2)) * **Wysiwyg Editor, Rich Text Editor:** add wysiwyg component for vue3 ([#117](#117)) ([bc93fb8](bc93fb8))
braddialpad
pushed a commit
that referenced
this pull request
Feb 1, 2024
# [9.10.0](dialtone/v9.9.0...dialtone/v9.10.0) (2024-02-01) ### Bug Fixes * change padding on right slot of call pill stories ([#138](#138)) ([9a23a42](9a23a42)) * **Feed Item Row, Emoji Row:** spacing / color fixes - Vue 3 ([#134](#134)) ([21f3e21](21f3e21)) * **Feed Item Row:** set inset focus ring on feed item ([#139](#139)) ([e4e935a](e4e935a)) * name of the office365-calendar icon ([#137](#137)) ([7c86bb0](7c86bb0)) ### Features * **Wysiwyg Editor, Rich Text Editor:** add wysiwyg component ([#113](#113)) ([367d3e2](367d3e2)) * **Wysiwyg Editor, Rich Text Editor:** add wysiwyg component for vue3 ([#117](#117)) ([bc93fb8](bc93fb8))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forgot to copy these changes to vue 3, whoops