-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(documentation-site): NO-JIRA enhance sidebar #406
Conversation
Awesome! Good use of Collapsible. I'll list some comments below as individual comments rather than one long one: |
The Content page should have its own grid of child items listed too, like the attached faked screenshot below. Those same items should not appear on the Guides landing page. ![]() |
When arriving on the Guides page, the Content item should remain collapsed. |
The Content left-nav item should be a single target. Clicking anywhere on the row expands and navigates to that page, it does not collapse. |
At the moment, we only want items that have children to be a Collapsible. That is, only "Content" on Guides should be collapsible. The following left-nav titles should not be collapsible:
As an example, arriving on Guides should appears like so... |
I agree with @francisrupert. Other than that, this LGTM! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Officially marking as "request changes", refer to standalone comments above.
The Content section should be collapsed if the current page is not within Content section. Screen.Recording.2024-07-12.at.3.46.01.PM.mov |
The leftnav should not expand when arriving at a page. Perhaps this is a limitation of DtCollapsible, but it appears to be collapsed onload and then expand onload. Screen.Recording.2024-07-12.at.3.48.47.PM.mov |
Thought it'd not collapse once opened by this comment
Misunderstood the behavior, fixing it 😅 |
Please add either the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small change here to increase the space between sections between sections on the Utilities page.
@@ -5,7 +5,7 @@ | |||
<dt-stack | |||
v-if="sidebarItems[0]?.children.length" | |||
as="ul" | |||
gap="500" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
@juliodialpad Tertiary menu items are using Let's remove that utility class. The indentation is sufficient IMO |
Found a ticket but not quite sure it's exactly what you're mentioning: https://dialpad.atlassian.net/browse/DLT-895 ![]() I did this fix in the meantime. |
Just pushed a fix that might address that. |
…o lighten the selected TOC surface color.
@juliodialpad I still was seeing the font weight so I went ahead and make the corrections myself. Please review and let me know. |
✔️ Deploy previews ready! |
Josh approved it and Francis is OOO. Everything looks LGTM
Enhance sidebar
Obligatory GIF (super important!)
🛠️ Type Of Change
These types will not increment the version number, but will still deploy to documentation site on release:
📖 Description
💡 Context
Nested categories requested by Francis.
📝 Checklist
For all PRs:
📷 Screenshots / GIFs