Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: DLT-1796 move storybook to doc site - Link to Pagination #441

Merged
merged 8 commits into from
Aug 16, 2024

Conversation

ninamarina
Copy link
Contributor

@ninamarina ninamarina commented Aug 12, 2024

docs: DLT-1796 move storybook to doc site - Link to Pagination

  • Link (no changes)
  • List Item (updated)
  • List item group (added)
  • Modal (updated)
  • Notice (updated)
  • Pagination (updated)

Obligatory GIF (super important!)

Obligatory GIF

🛠️ Type Of Change

These types will increment the version number on release:

  • Fix
  • Feature
  • Performance Improvement
  • Refactor

These types will not increment the version number, but will still deploy to documentation site on release:

  • Documentation
  • Build system
  • CI
  • Style (code style changes, not css changes)
  • Test
  • Other (chore)

📖 Jira Ticket

DLT-1796

📝 Checklist

For all PRs:

  • I have ensured no private Dialpad links or info are in the code or pull request description (Dialtone is a public repo!).
  • I have reviewed my changes.
  • I have added all relevant documentation.
  • I have considered the performance impact of my change.

Copy link

Please add either the visual-test-ready or no-visual-test label to this PR depending on whether you want to run visual tests or not.
It is recommended to run visual tests if your PR changes any UI. ‼️

@ninamarina ninamarina added the no-visual-test Add this tag when the PR does not need visual testing label Aug 13, 2024
@ninamarina ninamarina marked this pull request as ready for review August 13, 2024 20:56
Copy link
Contributor

@francisrupert francisrupert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

Comment on lines 144 to 150
### Fixed header and footer

This is the default behavior that adds the scroll automatically in the modal content and leaves the header and footer fixed.

<code-well-header>
<example-modal kind="fixed" />
</code-well-header>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This variant desperately needs a custom scrollbar. There's zero affordance that it's a scrollable area.

I know that's outside this tasks's scope. Can you log an issue and see if we can get that out sooner? An epic should probably be created to collect all the DT components and recipes that should a custom scrollbar.

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've chucked it in a new Epic alongside other ones I've identified.

Copy link
Contributor

@braddialpad braddialpad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice thanks! Just a couple small casing issues.

<code-well-header>
<dt-list-item-group
heading="Example Heading"
headingClass="d-fw-bold"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always use kebab case in the template for consistiency: heading-class


<code-well-header class="d-d-block">
<ul>
<dt-list-item navigationType="tab">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

navigation-type

Copy link

✔️ Deploy previews ready!
😎 Dialtone preview: https://dialtone.dialpad.com/deploy-previews/pr-441/
😎 Dialtone-vue 2 preview: https://dialtone.dialpad.com/vue/deploy-previews/pr-441/
😎 Dialtone-vue 3 the preview: https://dialtone.dialpad.com/vue3/deploy-previews/pr-441/

@ninamarina ninamarina merged commit bc2d57d into staging Aug 16, 2024
10 checks passed
@ninamarina ninamarina deleted the update/doc-site-sb branch August 16, 2024 17:39
juliodialpad pushed a commit that referenced this pull request Aug 16, 2024
# [9.67.0](dialtone/v9.66.0...dialtone/v9.67.0) (2024-08-16)

### Bug Fixes

* **Docs:** DLT-1994 use dialtone scrollbar in docsite ([#456](#456)) ([7db2c8c](7db2c8c))

### Documentation

* **Common Commands:** NO-JIRA add documentation about using local package ([#449](#449)) ([e9b8be1](e9b8be1))
* DLT-1796 move storybook to doc site - Link to Pagination ([#441](#441)) ([bc2d57d](bc2d57d))

### Features

* **Contact Info:** NO-JIRA add `avatarColor` prop to contact info recipe ([#448](#448)) ([77ea808](77ea808))
* **Input:** DLT-1945 add clear slot prop to rightIcon ([#455](#455)) ([0f90dd4](0f90dd4))

### Reverts

* NO-JIRA use require for json imports ([#454](#454)) ([606cfb3](606cfb3))
juliodialpad pushed a commit that referenced this pull request Aug 16, 2024
# [2.154.0](dialtone-vue2/v2.153.0...dialtone-vue2/v2.154.0) (2024-08-16)

### Bug Fixes

* **Docs:** DLT-1994 use dialtone scrollbar in docsite ([#456](#456)) ([7db2c8c](7db2c8c))

### Documentation

* DLT-1796 move storybook to doc site - Link to Pagination ([#441](#441)) ([bc2d57d](bc2d57d))

### Features

* **Contact Info:** NO-JIRA add `avatarColor` prop to contact info recipe ([#448](#448)) ([77ea808](77ea808))
* **Input:** DLT-1945 add clear slot prop to rightIcon ([#455](#455)) ([0f90dd4](0f90dd4))

### Reverts

* NO-JIRA use require for json imports ([#454](#454)) ([606cfb3](606cfb3))
juliodialpad pushed a commit that referenced this pull request Aug 16, 2024
# [3.147.0](dialtone-vue3/v3.146.0...dialtone-vue3/v3.147.0) (2024-08-16)

### Bug Fixes

* **Docs:** DLT-1994 use dialtone scrollbar in docsite ([#456](#456)) ([7db2c8c](7db2c8c))

### Documentation

* DLT-1796 move storybook to doc site - Link to Pagination ([#441](#441)) ([bc2d57d](bc2d57d))

### Features

* **Contact Info:** NO-JIRA add `avatarColor` prop to contact info recipe ([#448](#448)) ([77ea808](77ea808))
* **Input:** DLT-1945 add clear slot prop to rightIcon ([#455](#455)) ([0f90dd4](0f90dd4))

### Reverts

* NO-JIRA use require for json imports ([#454](#454)) ([606cfb3](606cfb3))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-visual-test Add this tag when the PR does not need visual testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants