-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: DLT-1796 move storybook to doc site - Link to Pagination #441
Conversation
Please add either the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💪
### Fixed header and footer | ||
|
||
This is the default behavior that adds the scroll automatically in the modal content and leaves the header and footer fixed. | ||
|
||
<code-well-header> | ||
<example-modal kind="fixed" /> | ||
</code-well-header> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This variant desperately needs a custom scrollbar. There's zero affordance that it's a scrollable area.
I know that's outside this tasks's scope. Can you log an issue and see if we can get that out sooner? An epic should probably be created to collect all the DT components and recipes that should a custom scrollbar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I logged the ticket here: https://dialpad.atlassian.net/browse/DLT-1983
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I've chucked it in a new Epic alongside other ones I've identified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice thanks! Just a couple small casing issues.
<code-well-header> | ||
<dt-list-item-group | ||
heading="Example Heading" | ||
headingClass="d-fw-bold" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Always use kebab case in the template for consistiency: heading-class
|
||
<code-well-header class="d-d-block"> | ||
<ul> | ||
<dt-list-item navigationType="tab"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
navigation-type
✔️ Deploy previews ready! |
# [9.67.0](dialtone/v9.66.0...dialtone/v9.67.0) (2024-08-16) ### Bug Fixes * **Docs:** DLT-1994 use dialtone scrollbar in docsite ([#456](#456)) ([7db2c8c](7db2c8c)) ### Documentation * **Common Commands:** NO-JIRA add documentation about using local package ([#449](#449)) ([e9b8be1](e9b8be1)) * DLT-1796 move storybook to doc site - Link to Pagination ([#441](#441)) ([bc2d57d](bc2d57d)) ### Features * **Contact Info:** NO-JIRA add `avatarColor` prop to contact info recipe ([#448](#448)) ([77ea808](77ea808)) * **Input:** DLT-1945 add clear slot prop to rightIcon ([#455](#455)) ([0f90dd4](0f90dd4)) ### Reverts * NO-JIRA use require for json imports ([#454](#454)) ([606cfb3](606cfb3))
# [2.154.0](dialtone-vue2/v2.153.0...dialtone-vue2/v2.154.0) (2024-08-16) ### Bug Fixes * **Docs:** DLT-1994 use dialtone scrollbar in docsite ([#456](#456)) ([7db2c8c](7db2c8c)) ### Documentation * DLT-1796 move storybook to doc site - Link to Pagination ([#441](#441)) ([bc2d57d](bc2d57d)) ### Features * **Contact Info:** NO-JIRA add `avatarColor` prop to contact info recipe ([#448](#448)) ([77ea808](77ea808)) * **Input:** DLT-1945 add clear slot prop to rightIcon ([#455](#455)) ([0f90dd4](0f90dd4)) ### Reverts * NO-JIRA use require for json imports ([#454](#454)) ([606cfb3](606cfb3))
# [3.147.0](dialtone-vue3/v3.146.0...dialtone-vue3/v3.147.0) (2024-08-16) ### Bug Fixes * **Docs:** DLT-1994 use dialtone scrollbar in docsite ([#456](#456)) ([7db2c8c](7db2c8c)) ### Documentation * DLT-1796 move storybook to doc site - Link to Pagination ([#441](#441)) ([bc2d57d](bc2d57d)) ### Features * **Contact Info:** NO-JIRA add `avatarColor` prop to contact info recipe ([#448](#448)) ([77ea808](77ea808)) * **Input:** DLT-1945 add clear slot prop to rightIcon ([#455](#455)) ([0f90dd4](0f90dd4)) ### Reverts * NO-JIRA use require for json imports ([#454](#454)) ([606cfb3](606cfb3))
docs: DLT-1796 move storybook to doc site - Link to Pagination
Obligatory GIF (super important!)
🛠️ Type Of Change
These types will increment the version number on release:
These types will not increment the version number, but will still deploy to documentation site on release:
📖 Jira Ticket
DLT-1796
📝 Checklist
For all PRs: