fix(tokens): NO-JIRA move themes to tokens package #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braddialpad
requested review from
juliodialpad,
iropolo,
francisrupert and
ninamarina
as code owners
braddialpad
added
the
visual-test-ready
juliodialpad
approved these changes
Aug 26, 2024
common/utils.js
Outdated
Comment on lines
6
to
17
| /** | ||
| * Transform a string from kebab-case to PascalCase | ||
| * @param string | ||
| * @returns {string} | ||
| */ | ||
| export function kebabCaseToPascalCase (string) { | ||
| return string?.toLowerCase() | ||
| .split('-') | ||
| .map(word => word.charAt(0).toUpperCase() + word.slice(1)) | ||
| .join(''); | ||
| } | ||
|
|
There was a problem hiding this comment.
I think your linter did this, right? this is being used on icon component IIRC
There was a problem hiding this comment.
I get this...
import { kebabCaseToPascalCase } from '../../common/utils.js';
^^^^^^^^^^^^^^^^^^^^^
SyntaxError: Named export 'kebabCaseToPascalCase' not found. The requested module '../../common/utils.js' is a CommonJS module, which may not support all module.exports as named exports.
CommonJS modules can always be imported via the default export, for example using:
import pkg from '../../common/utils.js';
const { kebabCaseToPascalCase } = pkg;
Do we need to rename this to utils.mjs since package.json is not type: "module" anymore?
There was a problem hiding this comment.
Changed this as I mentioned above, seems to have fixed it.
Comment on lines
18
to
29
| /** | ||
| * Transform a string from kebab-case to PascalCase | ||
| * @param string | ||
| * @returns {string} | ||
| */ | ||
| function kebabCaseToPascalCase (string) { | ||
| return string?.toLowerCase() | ||
| .split('-') | ||
| .map(word => word.charAt(0).toUpperCase() + word.slice(1)) | ||
| .join(''); | ||
| } | ||
|
|
There was a problem hiding this comment.
Why moving it to this file? I think that utility it's more general than just for build-sd-transforms, don't you think?
There was a problem hiding this comment.
Moved back with .mjs change mentioned above.
|
✔️ Deploy previews ready! |
juliodialpad
pushed a commit
that referenced
this pull request
Aug 26, 2024
# [9.70.0](dialtone/v9.69.1...dialtone/v9.70.0) (2024-08-26) ### Bug Fixes * NO-JIRA eslint documentation links ([#472](#472)) ([32f606b](32f606b)) * **Tokens:** NO-JIRA move themes to tokens package ([#476](#476)) ([ea8d977](ea8d977)) ### Features * **Contact Row:** NO-JIRA add `avatarColor` prop to contact row recipe ([#469](#469)) ([f0be39d](f0be39d)) * DP-108555 change prop type in contact centers recipe component ([#471](#471)) ([f45f302](f45f302)) ### Reverts * Revert "chore(release): NO-JIRA eslint-plugin-dialtone/v1.1.0" ([22736cb](22736cb))
juliodialpad
pushed a commit
that referenced
this pull request
Aug 26, 2024
## [1.34.2](dialtone-tokens/v1.34.1...dialtone-tokens/v1.34.2) (2024-08-26) ### Bug Fixes * **Tokens:** NO-JIRA move themes to tokens package ([#476](#476)) ([ea8d977](ea8d977))
juliodialpad
pushed a commit
that referenced
this pull request
Aug 26, 2024
# [2.157.0](dialtone-vue2/v2.156.1...dialtone-vue2/v2.157.0) (2024-08-26) ### Bug Fixes * **Tokens:** NO-JIRA move themes to tokens package ([#476](#476)) ([ea8d977](ea8d977)) ### Features * **Contact Row:** NO-JIRA add `avatarColor` prop to contact row recipe ([#469](#469)) ([f0be39d](f0be39d)) * DP-108555 change prop type in contact centers recipe component ([#471](#471)) ([f45f302](f45f302))
juliodialpad
pushed a commit
that referenced
this pull request
Aug 26, 2024
# [3.150.0](dialtone-vue3/v3.149.1...dialtone-vue3/v3.150.0) (2024-08-26) ### Bug Fixes * **Tokens:** NO-JIRA move themes to tokens package ([#476](#476)) ([ea8d977](ea8d977)) ### Features * **Contact Row:** NO-JIRA add `avatarColor` prop to contact row recipe ([#469](#469)) ([f0be39d](f0be39d)) * DP-108555 change prop type in contact centers recipe component ([#471](#471)) ([f45f302](f45f302))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(tokens): NO-JIRA move themes to tokens package
Obligatory GIF (super important!)
🛠️ Type Of Change
These types will increment the version number on release:
📖 Description
Moved the new theme logic and configuration to the tokens package instead of the root. Removed type: module from the root.
💡 Context
This change was causing all kinds of issues with imports on ES6 repos, due to
type: "module". Needed to be moved to a sub package.📝 Checklist
For all PRs:
🔮 Next Steps
Release and test in ui-kits and dx-console