-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: NO-JIRA tree-shaking #480
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good thanks!
✔️ Deploy previews ready! |
## [1.0.8](dialtone-emojis/v1.0.7...dialtone-emojis/v1.0.8) (2024-08-29) ### Bug Fixes * NO-JIRA tree-shaking ([#480](#480)) ([f24eb29](f24eb29))
## [4.26.6](dialtone-icons/v4.26.5...dialtone-icons/v4.26.6) (2024-08-29) ### Bug Fixes * NO-JIRA tree-shaking ([#480](#480)) ([f24eb29](f24eb29))
## [2.157.1](dialtone-vue2/v2.157.0...dialtone-vue2/v2.157.1) (2024-08-29) ### Bug Fixes * NO-JIRA tree-shaking ([#480](#480)) ([f24eb29](f24eb29))
## [3.150.1](dialtone-vue3/v3.150.0...dialtone-vue3/v3.150.1) (2024-08-29) ### Bug Fixes * NO-JIRA tree-shaking ([#480](#480)) ([f24eb29](f24eb29))
## [1.0.8](dialtone-emojis/v1.0.7...dialtone-emojis/v1.0.8) (2024-08-29) ### Bug Fixes * NO-JIRA tree-shaking ([#480](#480)) ([f24eb29](f24eb29))
## [4.26.6](dialtone-icons/v4.26.5...dialtone-icons/v4.26.6) (2024-08-29) ### Bug Fixes * NO-JIRA tree-shaking ([#480](#480)) ([f24eb29](f24eb29))
## [2.157.1](dialtone-vue2/v2.157.0...dialtone-vue2/v2.157.1) (2024-08-29) ### Bug Fixes * NO-JIRA tree-shaking ([#480](#480)) ([f24eb29](f24eb29))
## [3.150.1](dialtone-vue3/v3.150.0...dialtone-vue3/v3.150.1) (2024-08-29) ### Bug Fixes * NO-JIRA tree-shaking ([#480](#480)) ([f24eb29](f24eb29))
Fix tree-shaking
Obligatory GIF (super important!)
🛠️ Type Of Change
These types will increment the version number on release:
📖 Description
"sideEffects": false
to package's package.json files."packageManager": "[email protected]"
to root package to set the right package manager we want to use and avoid confusions on which version should be used.--skip-nx-cache
flag topnpm prepack
to improve the reliability of thepnpm pack
command.💡 Context
We we're having issues with tree-shaking:
import { DtAvatar } from '@dialpad/dialtone/vue3'
Wasn't working ❌import { DtAvatar } from '@dialpad/dialtone/vue3/lib/avatar'
Was working ✅With this fix, both ways of importing should work correctly, at least on Vite, as noted on the README.md
📝 Checklist
For all PRs:
For all Vue changes:
./scripts/dialtone-vue-sync.sh
script. Read docs here: Dialtone Vue Sync Script🔮 Next Steps
Merge staging to beta and release a new version to test @ninarepeto DtAvatar changes.