fix(emoji-picker): NO-JIRA fix ref reactivity in vue2 #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add either the |
|
✔️ Deploy previews ready! |
iropolo
changed the title
iropolo
requested review from
juliodialpad,
francisrupert,
braddialpad and
ninamarina
as code owners
braddialpad
approved these changes
Sep 27, 2024
juliodialpad
pushed a commit
that referenced
this pull request
Sep 27, 2024
## [9.76.3](dialtone/v9.76.2...dialtone/v9.76.3) (2024-09-27) ### Bug Fixes * **Emoji Picker:** NO-JIRA fix ref reactivity in vue2 ([#512](#512)) ([c4255c1](c4255c1)) * **Input:** DLT-2083 fix clear button margin ([#507](#507)) ([57bd549](57bd549)) * **Rich Text Editor:** DLT-2029 double line breaks on paste ([#511](#511)) ([d7b771a](d7b771a))
juliodialpad
pushed a commit
that referenced
this pull request
Sep 27, 2024
## [2.161.2](dialtone-vue2/v2.161.1...dialtone-vue2/v2.161.2) (2024-09-27) ### Bug Fixes * **Emoji Picker:** NO-JIRA fix ref reactivity in vue2 ([#512](#512)) ([c4255c1](c4255c1)) * **Input:** DLT-2083 fix clear button margin ([#507](#507)) ([57bd549](57bd549)) * **Rich Text Editor:** DLT-2029 double line breaks on paste ([#511](#511)) ([d7b771a](d7b771a))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(emoji-picker): no-jira fix ref reactivity in vue2
There were a bug on ref reactivity in vue2 version.
We already did a method to bypass this using
setupTabLabelRefsmethod in themountedsection.Previously
tabLabelscomputed was working with the refs, and this refs were not updated accordingly.Now we just leave the refs calculation to the
setupTabLabelRefsmethod since this is being call inside thethis.$nextTickand it just use the labels oftabLabels.To test this improvement, you can go to
packages/dialtone-vue2/components/emoji_picker/emoji_picker.stories.jsand remove the
recentlyUsedEmojisfromargsData.You will see now works properly with
SMILEYS AND PEOPLEtab labelPreviously it shows
MOST RECENTLY USEDtab label