Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flakiness in test com.dianping.cat.message.context.MessageIdFactoryTest#testDefaultDomainInParallel #2317

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hofi1
Copy link

@hofi1 hofi1 commented Oct 13, 2023

Problem:

This test is flaky due to the fact that the time which is provided (to shut the pool down) can be sufficient or not. It can fail to shut the pool down in the provided time (what results in a failed test)
If the code remains the way it is, it results in a flaky test which sometimes passes and might fail other times (non-deterministic behavior).

Solution:

I added the condition if the shutdown is finished or if it failed. Furthermore, the duration for the shutdown got increased to make sure, that it is possible to finish the process without running in a timeout. If the shutdown reaches the timeout, the test fails as intended. If the shutdown is finished successfully, the same conditions (asserts) apply as before.

Result:

The test is deterministic and not flaky. This improves the quality of the test and reduces the time to search for the bug during future development.

@hofi1 hofi1 force-pushed the bugfix/fix-flakiness-in-test branch from ada9cb2 to 1f8c392 Compare October 14, 2023 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant