Reduce name length in save files

[kphoenix137]

The game only allows players to create a name of length 15, so we can reduce the size of pName to 16 bytes (leaves 1 byte for the null-terminated character). This opens up free space which could be used for modding purposes, although using this space could cause problems if save files were moved back to vanilla, since it loads 32 bytes rather than 16. (Not sure if the null-terminated character would ignore the rest of the bytes or not)

[StephenCWills]

Do we care whether renaming MP characters via the Battle.net option can exceed 15 characters?

[kphoenix137]

Do we care whether renaming MP characters via the Battle.net option can exceed 15 characters?

Yes. I hadn't considered this.

[kphoenix137]

Do we care whether renaming MP characters via the Battle.net option can exceed 15 characters?

Constantine confirmed it's 15.

[StephenCWills]

using this space could cause problems if save files were moved back to vanilla

I suppose the issue would be that the data used by mods would only be captured in the Single Player save file. PackPlayer() uses strcpy() which only copies bytes up to the null-terminating character. Creating a new game and saving in vanilla Diablo would cause the mod's data to be lost.

But maybe the unused bytes could be used by computed values like extra item flags. Something that could be computed on load. I'm not sure if that's what you had in mind by making this change.

[kphoenix137]

using this space could cause problems if save files were moved back to vanilla

I suppose the issue would be that the data used by mods would only be captured in the Single Player save file. PackPlayer() uses strcpy() which only copies bytes up to the null-terminating character. Creating a new game and saving in vanilla Diablo would cause the mod's data to be lost.

But maybe the unused bytes could be used by computed values like extra item flags. Something that could be computed on load. I'm not sure if that's what you had in mind by making this change.

The modding part was just a potential suggestion. I suppose it would make it easier for forwards compatibility with mods that want to save more data to the player struct, since adding more fields ends up making existing saves before the field was added unrecognized.