Options: More untangling #7652
Merged
Options: More untangling #7652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Options now only contain the padmapper settings, not the padmapping handling code.
glebm
changed the title
glebm
force-pushed
the
more-options-cleanup
branch
from
229d08a to
c27f3c7
Compare
Removes a transitive dependency on the entire plrctrl from options.
glebm
force-pushed
the
more-options-cleanup
branch
from
c27f3c7 to
9e54c90
Compare
AJenbo
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More Options untangling.
With this, the only remaining unaddressed options dependency is the sound stuff from what I can tell.