Merge pull request #1355 from dib-lab/fix/1353

Fix #1353
dib-lab · Feb 14, 2017 · 6dd8430 · 6dd8430
2 parents 4f1f0cc + 9b4b038
commit 6dd8430
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/lib/kmer_hash.cc b/lib/kmer_hash.cc
@@ -184,6 +184,12 @@ HashIntoType _hash_murmur(const std::string& kmer,
     h = out[0];
 
     std::string rev = khmer::_revcomp(kmer);
+    if (rev == kmer) {
+        // self complement kmer, can't use bitwise XOR
+        r = out[0];
+        return h;
+    }
+
     MurmurHash3_x64_128((void *)rev.c_str(), rev.size(), seed, &out);
     r = out[0];
 

diff --git a/tests/test_functions.py b/tests/test_functions.py
@@ -153,6 +153,9 @@ def test_hash_murmur3():
     assert khmer.hash_murmur3('TTTT') == 526240128537019279
     assert khmer.hash_murmur3('CCCC') == 14391997331386449225
     assert khmer.hash_murmur3('GGGG') == 14391997331386449225
+    assert khmer.hash_murmur3('TATATATATATATATATATA') != 0
+    assert khmer.hash_murmur3('TTTTGCAAAA') != 0
+    assert khmer.hash_murmur3('GAAAATTTTC') != 0
 
 
 def test_hash_no_rc_murmur3():