-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open PR for Streaming Partitioning #1502
base: feature/assembly/junction_count
Are you sure you want to change the base?
Open PR for Streaming Partitioning #1502
Conversation
Digging into this to compare to #1538's benchmarks. Mainly interested in the cython stuff. Compiling dc0d0a6 fails with:
on OSX 10.11.6 with:
|
setup.py
Outdated
@@ -144,7 +166,7 @@ def check_for_openmp(): | |||
EXTRA_COMPILE_ARGS = ['-O3', '-std=c++11', '-pedantic'] | |||
EXTRA_LINK_ARGS = [] | |||
|
|||
if sys.platform == 'darwin': | |||
if sys.platform == 'darwin' and 'clang' in os.getenv('CC', 'cc'): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removing this new check fixes the compilation problems. Not sure what a better way of detecting that we are using clang
vs gcc
is though as on OSX the default compiler is clang
but it also responds to call to gcc
etc. Only thing I can think of is looking at the output of gcc --version
. Are there any people who use actual gcc
on OSX?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes... I was trying to get gcc compilation working on OSX, because the gcc compiled version is much faster than the clang one, for reasons that aren't clear. This is probably what's borking it on @ctb 's machine as well.
enable static building using pkg-config
…o refactor/hashing2
Resolving the pytest-runner dependency sometimes fails when there is no network but not always. This fixes the symptom but probably isn't the correct long term fix.
A halfway house between storing counts in a full byte and only tracking presence/absence. Uses four bits to track counts for each kmer.
…d remove need to install seqan headers
Open PR for working on streaming partitioning. Note that this PR contains the JunctionCountAssembler changes. Some tentative plans...
SubsetPartition
, though in parallel; it doesn't use the existing tagging system, and doesn't attempt to detect lumps. Mostly sketched out now, needs testing and stuff.make test
Did it pass the tests?make clean diff-cover
If it introduces new functionality inscripts/
is it tested?make format diff_pylint_report cppcheck doc pydocstyle
Is it wellformatted?
without a major version increment. Changing file formats also requires a
major version number increment.
ChangeLog
?http://en.wikipedia.org/wiki/Changelog#Format
changes were made?
tested for streaming IO?)