-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] Drop __future__ imports #1786
Conversation
I'll handle merging this back into #1774, including conflicts if there are any. |
Ready for review @ctb @luizirber @betatim! |
Codecov Report
@@ Coverage Diff @@
## master #1786 +/- ##
=========================================
- Coverage 0.06% 0.05% -0.02%
=========================================
Files 78 78
Lines 9792 9757 -35
Branches 2457 2457
=========================================
- Hits 6 5 -1
+ Misses 9786 9752 -34
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me!
Before I hit merge, do you want to merge this into master or #1774? The PR says master but your comment makes me wonder. |
Definitely into master. It's a subset of changes from #1774, which I'm trying to break into smaller more manageable chunks. I'll resolve any conflicts on that branch that arise from merging this PR. |
Now that we've dropped Python 2 support,
__future__
imports are unnecessary. Aside from the Makefile, all changes to the code in this PR were made bygrep -v
and shell for loops.NB: Splitting this out from #1774 to simplify code review.
make test
Did it pass the tests?make clean diff-cover
If it introduces new functionality inscripts/
is it tested?make format diff_pylint_report cppcheck doc pydocstyle
Is it wellformatted?
documented in
CHANGELOG.md
? See keepachangelogfor more details.