-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create version of logback appender with AWS SDK v2 dependencies #7
Conversation
Hi @valters I moved your fork into my rep as branch aws-v2. I want to evaluate it a bit more before I merge it. (I have to think about if it makes sense to keep both versions (aws-v1 and aws-v2) or if I move to aws-v2. |
The AWS SDK v2 is a huge departure over v1, everything is changed. Mind you, v2 looks modern and I love it. But my opinion also is that v1 will continue to be maintained almost indefinitely. They way v1 and v2 are designed, the artifacts actually could be used side-by-side. So I guess a piece-by-piece migration is doable. But a lot of people will simply never upgrade, because v1 simply is "good enough". |
I still wondering how to keep both AWS versions. Currently I have put your changes into a branch and thought about to use version 1.* for the old version and 2.* for the AWS v2 version. What do you think? (I still need to test the AWS v2 stuff behind a corporate firewall and see how the missing ClientConfig worsk there) |
Yes, I am all for releasing 2.* for using with AWS v2. Thanks! The client config seems to be renamed to ProxyConfig. https://github.com/aws/aws-sdk-java-v2/blob/master/docs/LaunchChangelog.md#132-client-http-proxy-configuration (I don't have a proxy, so I would have hard time testing.) |
Hello @valters, could you please have a look at
You can find the README here: Cheers, |
I'll open an issue to discuss the AWS SDK V2 here: |
I'll have merged your changes manually and will close this merge request. |
Hi,
I am using AWS SDK v2 for some green-field projects, and thought it would be nice to to have the cloudwatch appender also use v2 dependencies.
For the appender it would mean maintaing/releasing two versions. (This should not be merged to master, but to some aws-v2 branch to be maintained in parallel with v1 stream.)
Note I could not figure out replacement for the ClientConfig, so I removed it for now. In AWS SDK v2 they (among other things) seem to have hidden the proxy overrides, etc, somewhere in http client config, but I was not able to find it.