-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added change engine mic state and mode on caster startup for DNS #815
Merged
LexiconCode
merged 5 commits into
dictation-toolbox:master
from
LexiconCode:engine_manager
May 30, 2020
Merged
Added change engine mic state and mode on caster startup for DNS #815
LexiconCode
merged 5 commits into
dictation-toolbox:master
from
LexiconCode:engine_manager
May 30, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have a little bit of work to do with the logic in set_engine_mode. Feel free to suggest improvements. |
e392b72
to
411dbce
Compare
Okay this should work as expected now and I've simplified logic. |
4fd24fe
to
9c991e5
Compare
- prep for implementation for modes on other engines
75c7b59
to
5d66f5a
Compare
6295c79
to
5c15131
Compare
d171300
to
c6685dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Caster Core Spec
Issues for Caster Specs that are not part of the application or language specific grammar/ccr
Complete
Pull request is complete and tested as defined by Contributor
Dragon Naturally Speaking
Dragon NaturallySpeaking Engine Backend: Include version the issue. Ex. DNS 15
New Feature
A new feature that is not currently implemented.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added setting change engine mic state and mode on caster startup defined in settings.toml
Outside of changing modes on startup switching modes set_mic_mode and set_engine_mode will not be fully implemented until exclusivity is added for all engines.
Valid "mic_mode" settings.
Valid "engine_mode" settings.
Related Issue
Relevant to implementing sleep/modes for other engines #797
Motivation and Context
This gives the user control over their startup experience with both the engine mode and mic. This is implemented for DNS only at the moment but in a separate PR due to the scope of testing and implementation for using grammar exclusivity.
How Has This Been Tested
This is been tested with DNS
Types of changes
Checklist
Maintainer/Reviewer Checklist