Auto-generated Pull Request for feat/geneid-test #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…oncatenation The new document outlines coding conventions, specifically recommending the use of at least three-letter variable names and the use of fmt.Sprintf for string concatenation.
…sitive data exposure The addition of .aider* and .env to the .gitignore file prevents sensitive files and temporary artifacts from being tracked in the repository, ensuring that sensitive information such as environment variables does not get exposed.
New filter constants are introduced for gene filtering, and a test function is added to verify the functionality of listing strains based on specific gene criteria.
The depguard linter is removed to streamline the linting process and reduce potential false positives.
…istency Introduce a 100 millisecond sleep delay in the plasmid and strain tests to allow for data consistency during concurrent operations. This change helps to mitigate potential race conditions when adding plasmids and strains, ensuring that the tests accurately reflect the state of the database after modifications.
The dagger.json file is added to manage running ci/cd for the modware-import project.
…or consistency with naming conventions The function name is updated to use "IDs" instead of "Ids" to align with common conventions for pluralizing "ID". This change enhances code readability and maintains consistency across the codebase.
…or consistency in naming conventions The changes standardize the naming of identifiers related to "IDs" by using the plural form "IDs" instead of "Ids".
…onsistency Adding the pluralization of "IDs" in the test function and method names improves clarity and consistency with common terminology in programming, ensuring that the naming convention reflects the nature of the data being handled. Additionally, a sleep delay is introduced in the `createTestStrains` function to prevent potential race conditions during tests.
…res and performance The Go version is updated to 1.22 to take advantage of the latest features, performance improvements, and bug fixes introduced in this release. This ensures the project remains up-to-date with the latest Go enhancements.
…and compatibility The Go version is updated to 1.22 across all CI workflows to ensure consistency and compatibility with the latest features and improvements. Additionally, the ArangoDB image is upgraded to version 3.11 to benefit from enhanced features and security updates.
…nting process The lint job is replaced with a call-lint job that utilizes a reusable workflow from dictyBase. This change simplifies the configuration and ensures consistency in linting across different repositories by leveraging a centralized linting workflow.
…eamline linting process Removing the dupl linter simplifies the linting process, as it may not be necessary for the current project needs. This change helps to focus on more relevant linters and reduces potential noise in the linting output.
pull request triggers The develop branch is now ignored for pull request linting to prevent unnecessary lint checks on branches that are not intended for production. This change streamlines the workflow and focuses linting efforts on relevant branches only.
…uracy in linting
Changing the reference from `${{ github.ref_name }}` to `${{
github.event.pull_request.head.sha }}` ensures that the linting job uses
the exact commit from the pull request, improving the accuracy of the
linting process and preventing potential issues with branch references.
…equest trigger The develop branch is no longer ignored in the pull request trigger, allowing linting checks to run on pull requests targeting the develop branch. This change ensures that code quality checks are consistently applied across all branches, improving overall code integrity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulling 'feat/geneid-test into develop. Please review and merge.