Adding open telemetry #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Questions.
Do I need to add all three open telemetry libraries (core, api and zipkin)
Is zipkin the easiest tool to set up locally, simple docker setup but I still haven't sucessfully sent any spans to it.
Is the default zipkin configuration going to work for localhost 9411. Add documentation for how to run using mix opentelemetry-beam/opentelemetry_zipkin#15
Have any breaking changes happened between 0.4.0 and 0.5.0 that affect zipkin integration. Support opentelemetry and api libraries version 0.5.0 opentelemetry-beam/opentelemetry_zipkin#17
Follow the elli example to add tracing https://github.com/opentelemetry-beam/opentelemetry_elli/blob/master/src/otel_elli.erl
Definition of span record https://github.com/open-telemetry/opentelemetry-erlang/blob/master/apps/opentelemetry/include/otel_span.hrl
most open telemetry type definitions https://github.com/open-telemetry/opentelemetry-erlang/blob/master/apps/opentelemetry_api/src/opentelemetry.erl