-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
2 changed files
with
82 additions
and
46 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,28 @@ | ||
### How to send Pull request | ||
Welcome to send pull request to VirtualAPK, but you should read the following notes before your contribution. | ||
# Contribution Guideline | ||
|
||
1. Branch: only branch ```dev``` will accept pull request, so not send your pull request to other branch. | ||
2. Code style and name format: please refer to the code style of Android and VirtualAPK. | ||
3. Format of commit message when submit code by git: only English message that spelled Correctly is accepted. | ||
4. Test: you should test your code before sending pull request, It's recommended that add ```device mode```, ```API version```, ```log```, ```photos``` and etc with your pull request. | ||
Thanks for considering to contribute this project. All issues and pull requests are highly appreciated. | ||
|
||
```Note```: make sure the code of your pull request is under the [Apache License 2.0](https://github.com/didi/VirtualAPK/blob/master/LICENSE). | ||
## Pull Requests | ||
|
||
### How to make issue | ||
Welcome to make issue for VirtualAPK, be sure to describe problems explicitly in the issue. It's also recommended that add ```device mode```, ```API version```, ```log```, ```photos``` in the issue. | ||
Before sending pull request to this project, please read and follow guidelines below. | ||
|
||
1. Branch: We only accept pull request on `dev` branch. | ||
2. Coding style: Follow the coding style used in VirtualAPK. | ||
3. Commit message: Use English and be aware of your spell. | ||
4. Test: Make sure to test your code. | ||
|
||
Add device mode, API version, related log, screenshots and other related information in your pull request if possible. | ||
|
||
NOTE: We assume all your contribution can be licensed under the [Apache License 2.0](https://github.com/didi/VirtualAPK/blob/master/LICENSE). | ||
|
||
## Issues | ||
|
||
We love clearly described issues. :) | ||
|
||
Following information can help us to resolve the issue faster. | ||
|
||
* Device mode and hardware information. | ||
* API version. | ||
* Logs. | ||
* Screenshots. | ||
* Steps to reproduce the issue. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters