fix: processShowStyle 添加是否为 virtualHost 的判断 #1777
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiyuki
reviewed
Dec 24, 2024
| const setUsingComponentInfo = (name, moduleId, hasVirtualHost) => { | ||
| usingComponentsInfo[name] = { | ||
| mid: moduleId, | ||
| hvh: hasVirtualHost |
hiyuki
reviewed
Dec 24, 2024
| @@ -78,8 +78,11 @@ module.exports = function ({ | |||
| componentGenerics = Object.assign({}, ret.componentGenerics) | |||
| } | |||
| if (usingComponents) { | |||
| const setUsingComponentInfo = (name, moduleId) => { | |||
| usingComponentsInfo[name] = { mid: moduleId } | |||
| const setUsingComponentInfo = (name, moduleId, hasVirtualHost) => { | |||
hiyuki
reviewed
Dec 24, 2024
| @@ -2189,6 +2189,10 @@ function isComponentNode (el, options) { | |||
| return usingComponents.indexOf(el.tag) !== -1 || el.tag === 'component' | |||
| } | |||
|
|
|||
| function isVirtualHostNode (el, options) { | |||
There was a problem hiding this comment.
isComponentNode 无效参数options删除
There was a problem hiding this comment.
usingComponentsInfo作为闭包变量，与usingComponents拉齐
There was a problem hiding this comment.
之前获取mid的逻辑也使用getComponentInfo获取，另外移除无效的||moduleId兜底
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
processShowStyle 添加是否为 virtualHost 的判断