Migrate globalUserSettings, dictionaryIndex and more to jotai
#175
Conversation
For lessons without an overview file, the overview key is not included in the lesson index entry.
Previously, when you clicked the "Study" button this would call startFlashcards and updateFlashcardsRecommendation() to progress the flashcards recommendations. The combination of that button and the recommendation progression on first render would inadvertently take 2 steps instead of 1. Now, we don't explicitly update the recommendation on click of "Study" and instead rely on the useEffect calling updateFlashcardsRecommendation() when flashcardsCourseLevel changes and on first render. Altogether, we progress the recommendation by 1 step when: - you click "Study" and then navigate back to Progress page - you click "Skip" - you select a flashcards level
|
@na2hiro Woohoo! This looks great, nice work. Thanks for this. In the previous work to migrate to Jotai, there was a change to study presets. After that change, I started seeing Sentry errors from trying to access I mention that here because I'm not sure if the changes to |
|
@na2hiro I also reviewed all the code in the PR, which looks good to me. And I pushed some minor commits, I hope you don't mind. |
|
Thanks for reviewing! I don't have an idea for the reason why |
|
@na2hiro any further thoughts on this? If not, I might add some extra guards around |
|
Sorry for the delay. I don't have good ideas |
The approach to using "Error" as a link title when recommended courses fails to get fetched has been removed so we'll never hit this code to change the UI in response to it. Changed in didoesdigital@7f5b188
|
This is now in production! Thanks @na2hiro 👏 I'll make a note if I see any Sentry errors around experiments. |
This is a continuation of App breakdown & state migration to Jotai. Mostly each commit corresponds to each state that's migrated to Jotai atom.
Though I've quickly checked there's no errors on storybook, I couldn't have enough time to test using the app itself, because I've gotten busier recently (in fact, most of the changes were made in May). I thought it's rather better to share and not lose the progress I made so far or diverge too much from master.