-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨Improve error detail when re-requesting credential #1194
Closed
Closed
+96
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cl0ete
approved these changes
Nov 21, 2024
ff137
changed the title
✨ Improve error detail when re-requesting credential
✨Improve error detail when re-requesting credential
Nov 21, 2024
Changes 400: `create_request() called multiple times for v2.0 credential exchange ...` to 409: `Credential ... has already been issued`
ff137
force-pushed
the
improve-cred-already-issued-error-msg
branch
from
November 22, 2024 23:27
79a7125
to
c7f4269
Compare
Quality Gate passedIssues Measures |
Cannot replicate the error |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes 400:
create_request() called multiple times for v2.0 credential exchange ...
to 409:
Credential ... has already been requested
Edit: needs #1196
Edit2: also needs custom wallet settings to not autocomplete flow, in order to replicate