Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Improve error detail when re-requesting credential #1194

Closed
wants to merge 7 commits into from

Conversation

ff137
Copy link
Collaborator

@ff137 ff137 commented Nov 21, 2024

Changes 400: create_request() called multiple times for v2.0 credential exchange ...
to 409: Credential ... has already been requested

Edit: needs #1196

Edit2: also needs custom wallet settings to not autocomplete flow, in order to replicate

@ff137 ff137 requested a review from cl0ete November 21, 2024 09:34
@ff137 ff137 self-assigned this Nov 21, 2024
@ff137 ff137 added the enhancement New feature or request label Nov 21, 2024
app/services/issuer/acapy_issuer_v2.py Dismissed Show dismissed Hide dismissed
@ff137 ff137 changed the title ✨ Improve error detail when re-requesting credential ✨Improve error detail when re-requesting credential Nov 21, 2024
@ff137 ff137 marked this pull request as draft November 21, 2024 10:33
Changes 400: `create_request() called multiple times for v2.0 credential exchange ...` to 409: `Credential ... has already been issued`
@ff137 ff137 marked this pull request as ready for review December 3, 2024 11:56
Copy link

sonarcloud bot commented Dec 3, 2024

@ff137
Copy link
Collaborator Author

ff137 commented Dec 3, 2024

Cannot replicate the error

@ff137 ff137 closed this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants