DiemID Refactor #185
DiemID Refactor #185
Conversation
dips/dip-10.md
Outdated
|
|
||
| The format of the command is: | ||
|
|
||
| ``` | ||
| { | ||
| "_ObjectType": "CommandRequestObject", | ||
| "command_type": "ReferenceIDCommand", | ||
| "command_type": "SenderInitiatedReferenceID", |
There was a problem hiding this comment.
If we are going to rename this command, I suggest new name "ExchangePaymentAddress".
The reason is, for this command, what really need is for sender to get receiver's account address, when sender got receiver's DiemID.
We originally thought reference id is the data need to be exchanged. But I think reference id is an id for referencing the payment that uses DiemID and related account addresses.
It is better to not assume this is a command initiate the reference id, because if we had another command that needs exchange information between VASPs, and the command happens before this command, then we may have trouble.
There was a problem hiding this comment.
Yeah, naming could definitely be improved!
There was a problem hiding this comment.
We can call it SenderInitiatedDiemIdExchange if we want to be specific to be diemID and not mention reference ID, since we're worried that reference ID exchange could happen in other commands
There was a problem hiding this comment.
I think SenderInitiatedDiemIDExchange is a good name, clearly described the business needs.
Refactoring DiemID DIP into three DIPS: Diem ID (DIP-10), On-chain domain resolution (#187), and Reference ID exchange (#186).