getting started integration tests #4087
Conversation
|
This is my first ever open-source pr, so if there are any good practices that I can add to the tests/description, I am glad to take reviews on that as well. |
VicVerevita
changed the title
VicVerevita
changed the title
| @@ -7,6 +7,7 @@ publish = false | |||
| [dependencies] | |||
| diesel = { version = "2.1.0", path = "../../../diesel", features = ["mysql"] } | |||
| dotenvy = "0.15" | |||
| assert_cmd = "2.0.14" | |||
There was a problem hiding this comment.
This should be a dev-dependency as we only use that in tests
| @@ -7,6 +7,7 @@ publish = false | |||
| [dependencies] | |||
| diesel = { version = "2.1.0", path = "../../../diesel", features = ["mysql"] } | |||
| dotenvy = "0.15" | |||
| assert_cmd = "2.0.14" | |||
There was a problem hiding this comment.
This should be a dev-dependency as we only use that in tests
| @@ -7,6 +7,7 @@ publish = false | |||
| [dependencies] | |||
| diesel = { version = "2.1.0", path = "../../../diesel", features = ["mysql"] } | |||
| dotenvy = "0.15" | |||
| assert_cmd = "2.0.14" | |||
There was a problem hiding this comment.
This should be a dev-dependency as we only use that in tests
| @@ -7,6 +7,7 @@ publish = false | |||
| [dependencies] | |||
| diesel = { version = "2.1.0", path = "../../../diesel", features = ["postgres"] } | |||
| dotenvy = "0.15" | |||
| assert_cmd = "2.0.14" | |||
There was a problem hiding this comment.
This should be a dev-dependency as we only use that in tests
| @@ -7,6 +7,7 @@ publish = false | |||
| [dependencies] | |||
| diesel = { version = "2.1.0", path = "../../../diesel", features = ["postgres"] } | |||
| dotenvy = "0.15" | |||
| assert_cmd = "2.0.14" | |||
There was a problem hiding this comment.
This should be a dev-dependency as we only use that in tests
| @@ -7,6 +7,7 @@ publish = false | |||
| [dependencies] | |||
| diesel = { version = "2.1.0", path = "../../../diesel", features = ["postgres"] } | |||
| dotenvy = "0.15" | |||
| assert_cmd = "2.0.14" | |||
There was a problem hiding this comment.
This should be a dev-dependency as we only use that in tests
| @@ -10,6 +10,7 @@ publish = false | |||
| diesel = { version = "2.1.0", path = "../../../diesel", features = ["sqlite"] } | |||
| dotenvy = "0.15" | |||
| libsqlite3-sys = { version = "0.28.0", features = ["bundled"] } | |||
| assert_cmd = "2.0.14" | |||
There was a problem hiding this comment.
This should be a dev-dependency as we only use that in tests
| @@ -9,6 +9,7 @@ publish = false | |||
| diesel = { version = "2.1.0", path = "../../../diesel", features = ["sqlite", "returning_clauses_for_sqlite_3_35"] } | |||
| dotenvy = "0.15" | |||
| libsqlite3-sys = { version = "0.28.0", features = ["bundled"] } | |||
| assert_cmd = "2.0.14" | |||
There was a problem hiding this comment.
This should be a dev-dependency as we only use that in tests
| @@ -9,6 +9,7 @@ publish = false | |||
| diesel = { version = "2.1.0", path = "../../../diesel", features = ["sqlite", "returning_clauses_for_sqlite_3_35"] } | |||
| dotenvy = "0.15" | |||
| libsqlite3-sys = { version = "0.28.0", features = ["bundled"] } | |||
| assert_cmd = "2.0.14" | |||
There was a problem hiding this comment.
This should be a dev-dependency as we only use that in tests
|
Thanks again for working on this. This is good work for your first PR 🎉 |
I have picked up on the #777 issue. I saw that there was already a pull request tackling the integration tests for sqlite, so I started the postgresql ones.
To run the tests, I used the
test_allscript.