Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove more mentions of gitter #4361

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Remove more mentions of gitter #4361

merged 2 commits into from
Nov 26, 2024
+7 −13

Conversation

weiznich
Copy link
Member

I've searched and found more locations. That should hopefully be the last round of changes regarding to gitter.

@weiznich weiznich requested a review from a team November 26, 2024 07:38
kw217
kw217 suggested changes Nov 26, 2024
View reviewed changes
Copy link

@kw217 kw217 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! There's one more hiding in .github/ISSUE_TEMPLATE/config.yml which should also be removed. I think that's all of them now.

kw217
kw217 suggested changes Nov 26, 2024
View reviewed changes
Copy link

@kw217 kw217 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shouldn't say "Complex questions", it should just say "Questions". And the about needs to be updated to match, e.g., "Do you have a question? Ask in our forum".

kw217
kw217 approved these changes Nov 26, 2024
View reviewed changes
Copy link

@kw217 kw217 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks.

@weiznich weiznich added this pull request to the merge queue Nov 26, 2024
Merged via the queue into diesel-rs:master with commit a55f0fe Nov 26, 2024
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kw217 kw217 kw217 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weiznich @kw217